git.admin/roi-theme
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: move Analytics from ThemeSettings to AdsensePlacement

Browse Source 
- Remove Analytics and AdSense tabs from theme-settings component
- Add Analytics group to adsense-placement component
- Add roi_enqueue_analytics_script() for GA4/UA support
- Clean up ThemeSettings to only handle custom code (CSS/JS)
- Update FormBuilders and FieldMappers accordingly

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
FrankZamora
2025-11-27 18:43:39 -06:00
parent 3279b7df2b
commit b70e11be62
8 changed files with 193 additions and 357 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Admin/ThemeSettings/Infrastructure/FieldMapping/ThemeSettingsFieldMapper.php
View File

@@ -24,14 +24,6 @@ final class ThemeSettingsFieldMapper implements FieldMapperInterface
public function getFieldMapping(): array
{
return [
// Analytics
'themeSettingsGaTrackingId' => ['group' => 'analytics', 'attribute' => 'ga_tracking_id'],
'themeSettingsGaAnonymizeIp' => ['group' => 'analytics', 'attribute' => 'ga_anonymize_ip'],
// AdSense
'themeSettingsAdsensePublisherId' => ['group' => 'adsense', 'attribute' => 'adsense_publisher_id'],
'themeSettingsAdsenseAutoAds' => ['group' => 'adsense', 'attribute' => 'adsense_auto_ads'],
// Custom Code
'themeSettingsCustomCss' => ['group' => 'custom_code', 'attribute' => 'custom_css'],
'themeSettingsCustomJsHeader' => ['group' => 'custom_code', 'attribute' => 'custom_js_header'],

103
Admin/ThemeSettings/Infrastructure/Ui/ThemeSettingsFormBuilder.php
View File

@@ -9,9 +9,9 @@ use ROITheme\Admin\Infrastructure\Ui\AdminDashboardRenderer;
* FormBuilder para Theme Settings
*
* RESPONSABILIDAD: Generar formulario de configuraciones globales del tema
* (analytics, adsense, codigo personalizado)
* (codigo personalizado - CSS y JavaScript)
*
* NOTA: Logo/branding se gestiona desde el componente navbar
* NOTA: Analytics y AdSense se gestionan desde el componente adsense-placement
*
* @package ROITheme\Admin\ThemeSettings\Infrastructure\Ui
*/
@@ -29,14 +29,8 @@ final class ThemeSettingsFormBuilder
$html .= '<div class="row g-3">';
// Columna izquierda - Analytics + AdSense
$html .= '<div class="col-lg-6">';
$html .= $this->buildAnalyticsGroup($componentId);
$html .= $this->buildAdSenseGroup($componentId);
$html .= '</div>';
// Columna derecha - Custom Code
$html .= '<div class="col-lg-6">';
// Columna unica - Custom Code
$html .= '<div class="col-lg-8 mx-auto">';
$html .= $this->buildCustomCodeGroup($componentId);
$html .= '</div>';
@@ -56,7 +50,7 @@ final class ThemeSettingsFormBuilder
$html .= ' Configuraciones Globales del Tema';
$html .= ' </h3>';
$html .= ' <p class="mb-0 small" style="opacity: 0.85;">';
$html .= ' Analytics, AdSense y Codigo Personalizado';
$html .= ' Codigo Personalizado (CSS y JavaScript)';
$html .= ' </p>';
$html .= ' </div>';
$html .= ' <button type="button" class="btn btn-sm btn-outline-light btn-reset-defaults" data-component="theme-settings">';
@@ -69,62 +63,6 @@ final class ThemeSettingsFormBuilder
return $html;
}
private function buildAnalyticsGroup(string $componentId): string
{
$html = '<div class="card shadow-sm mb-3" style="border-left: 4px solid #1e3a5f;">';
$html .= ' <div class="card-body">';
$html .= ' <h5 class="fw-bold mb-3" style="color: #1e3a5f;">';
$html .= ' <i class="bi bi-graph-up me-2" style="color: #FF8600;"></i>';
$html .= ' Analytics';
$html .= ' </h5>';
$gaTrackingId = $this->renderer->getFieldValue($componentId, 'analytics', 'ga_tracking_id', '');
$html .= $this->buildTextInput('themeSettingsGaTrackingId', 'Google Analytics ID', 'bi-bar-chart', $gaTrackingId);
$html .= ' <div class="form-text small mb-2">Formato: G-XXXXXXXXXX o UA-XXXXXXXX-X</div>';
$gaAnonymizeIp = $this->renderer->getFieldValue($componentId, 'analytics', 'ga_anonymize_ip', true);
$html .= $this->buildSwitch('themeSettingsGaAnonymizeIp', 'Anonimizar IP (GDPR)', 'bi-shield-check', $gaAnonymizeIp);
$html .= ' <div class="alert alert-warning small mb-0 mt-2">';
$html .= ' <i class="bi bi-exclamation-triangle me-1"></i>';
$html .= ' Recomendado activar para cumplir con GDPR/RGPD';
$html .= ' </div>';
$html .= ' </div>';
$html .= '</div>';
return $html;
}
private function buildAdSenseGroup(string $componentId): string
{
$html = '<div class="card shadow-sm mb-3" style="border-left: 4px solid #1e3a5f;">';
$html .= ' <div class="card-body">';
$html .= ' <h5 class="fw-bold mb-3" style="color: #1e3a5f;">';
$html .= ' <i class="bi bi-badge-ad me-2" style="color: #FF8600;"></i>';
$html .= ' Google AdSense';
$html .= ' </h5>';
$publisherId = $this->renderer->getFieldValue($componentId, 'adsense', 'adsense_publisher_id', '');
$html .= $this->buildTextInput('themeSettingsAdsensePublisherId', 'Publisher ID', 'bi-key', $publisherId);
$html .= ' <div class="form-text small mb-2">Formato: ca-pub-1234567890123456</div>';
$autoAds = $this->renderer->getFieldValue($componentId, 'adsense', 'adsense_auto_ads', false);
$html .= $this->buildSwitch('themeSettingsAdsenseAutoAds', 'Activar Auto Ads', 'bi-magic', $autoAds);
$html .= ' <div class="alert alert-info small mb-0 mt-2">';
$html .= ' <i class="bi bi-info-circle me-1"></i>';
$html .= ' Auto Ads permite que Google coloque anuncios automaticamente en las mejores ubicaciones.';
$html .= ' </div>';
$html .= ' </div>';
$html .= '</div>';
return $html;
}
private function buildCustomCodeGroup(string $componentId): string
{
$html = '<div class="card shadow-sm mb-3" style="border-left: 4px solid #1e3a5f;">';
@@ -154,37 +92,6 @@ final class ThemeSettingsFormBuilder
return $html;
}
// Helper methods
private function buildSwitch(string $id, string $label, string $icon, $value): string
{
$checked = $value === true || $value === '1' || $value === 1 ? 'checked' : '';
$html = ' <div class="form-check form-switch mb-2">';
$html .= ' <input class="form-check-input" type="checkbox" id="' . esc_attr($id) . '" ' . $checked . '>';
$html .= ' <label class="form-check-label small" for="' . esc_attr($id) . '">';
$html .= ' <i class="bi ' . esc_attr($icon) . ' me-1" style="color: #FF8600;"></i>';
$html .= ' ' . esc_html($label);
$html .= ' </label>';
$html .= ' </div>';
return $html;
}
private function buildTextInput(string $id, string $label, string $icon, mixed $value): string
{
$value = $this->normalizeStringValue($value);
$html = ' <div class="mb-3">';
$html .= ' <label for="' . esc_attr($id) . '" class="form-label small mb-1 fw-semibold">';
$html .= ' <i class="bi ' . esc_attr($icon) . ' me-1" style="color: #FF8600;"></i>';
$html .= ' ' . esc_html($label);
$html .= ' </label>';
$html .= ' <input type="text" class="form-control form-control-sm" id="' . esc_attr($id) . '" value="' . esc_attr($value) . '">';
$html .= ' </div>';
return $html;
}
private function buildTextareaCode(string $id, string $label, string $icon, mixed $value, string $helpText = ''): string
{
$value = $this->normalizeStringValue($value);